Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake minimum should probably be bumped to 3.14 #1334

Open
meshula opened this issue Feb 15, 2023 · 1 comment
Open

cmake minimum should probably be bumped to 3.14 #1334

meshula opened this issue Feb 15, 2023 · 1 comment

Comments

@meshula
Copy link
Contributor

meshula commented Feb 15, 2023

vfx2020 specifies boost 1.70, which is supported in cmake 3.14 and later.

We specify cmake 3.12 as a minimum. If someone is building the boost-based Imath python bindings, it won't actually be a problem, because PyImath appears to be missing a find_package statement.

Probably we need to add a find_package statement to PyImath, and bump the version.

No one has noticed this, so it's a low priority.

@lgritz
Copy link
Contributor

lgritz commented Feb 15, 2023

I would be in favor of bumping cmake minimum moving forward. If you look at the VFX industry build matrix spreadsheet, you can see that a number of other projects in our ecosystem need higher than 3.12. In particular, OpenVDB and OpenTimelineIO both require 3.18, USD requires 3.14, OpenColorIO 3.13. Also, of all of the studios who have filled in their section, only one reports using older than 3.15, most are even beyond that.

I think bumping to 3.14 is conservative, I would consider going even higher. There are some nice things that come in 3.15 and 3.16. If you want to obey the "support dependencies and build tools up to 3 years back" rule, 3.17 was the one released 3 years ago (March 2020). By the time we "release" the next major version this summer, 3.18 will be 3 years old (July 2020).

Other data points: OIIO and OSL are both 3.12 still today, but I'm assuming I will bump by several releases by this summer's release season. I just haven't decided how far to move forward. But I'm certain it will be at least as far as 3.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants