-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refinement of how the code works #1059
Comments
That code is throwing an exception, because the IDManifest has been found to be in an unknown format. A calling program would need to take an appropriate action, such as catching the exception and showing a text alert. |
shouldn't we add the word |
You're right, that line is indeed missing a throw. It simply constructs the exception object and then it goes out of scope without being thrown, clearly an oversight. Good catch. |
Fixed #1062. |
haha, thanks for clarifying! I didn't notice the throw was missing! I have been looking at these macros too long and my brain filled in the blanks :) |
good day.
could you please clarify.
at this point are you expecting an exception to be thrown or just a text alert?
openexr/src/lib/OpenEXR/ImfIDManifest.cpp
Line 337 in 0d7e229
The text was updated successfully, but these errors were encountered: