Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refinement of how the code works #1059

Closed
ihsinme opened this issue Jun 22, 2021 · 5 comments
Closed

refinement of how the code works #1059

ihsinme opened this issue Jun 22, 2021 · 5 comments

Comments

@ihsinme
Copy link

ihsinme commented Jun 22, 2021

good day.
could you please clarify.
at this point are you expecting an exception to be thrown or just a text alert?

IEX_NAMESPACE::InputExc ("Unrecognized IDmanifest version");

@meshula
Copy link
Contributor

meshula commented Jun 22, 2021

That code is throwing an exception, because the IDManifest has been found to be in an unknown format. A calling program would need to take an appropriate action, such as catching the exception and showing a text alert.

@ihsinme
Copy link
Author

ihsinme commented Jun 22, 2021

shouldn't we add the word throw in this case?

@cary-ilm
Copy link
Member

You're right, that line is indeed missing a throw. It simply constructs the exception object and then it goes out of scope without being thrown, clearly an oversight. Good catch.

@cary-ilm
Copy link
Member

Fixed #1062.

@ihsinme ihsinme closed this as completed Jun 22, 2021
@meshula
Copy link
Contributor

meshula commented Jun 23, 2021

haha, thanks for clarifying! I didn't notice the throw was missing! I have been looking at these macros too long and my brain filled in the blanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants