Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Proxy support for EXR multipart output #4263

Closed
jreichel-nvidia opened this issue May 14, 2024 · 3 comments
Closed

[FEATURE REQUEST] Proxy support for EXR multipart output #4263

jreichel-nvidia opened this issue May 14, 2024 · 3 comments

Comments

@jreichel-nvidia
Copy link
Contributor

It looks as if EXR multipart output does not support I/O proxies. In my experiments all methods seem to succeed, but I never receive any data from my proxy. There is a comment in exroutput.cpp:

    // m_output_multipart.reset (new Imf::MultiPartOutputFile (*m_output_stream,
    //                                          &m_headers[0], subimages)();
    // FIXME: Oops, looks like OpenEXR 2.0 currently lacks a
    // MultiPartOutputFile ctr that takes an OStream, so we can't
    // do this quite yet.

Maybe I'm missing something but it looks as if that constructor is available since at least OpenEXR 2.0.0:

    MultiPartOutputFile (
        OStream&      os,
        const Header* headers,
        int           parts,
        bool          overrideSharedAttributes = false,
        int           numThreads               = globalThreadCount ());

Isn't that the one that is needed?

lgritz pushed a commit that referenced this issue May 16, 2024
Add proxy support for EXR multipart output by taking the setup code from
the other open() overload and calling the constructor accepting a stream
instead of a filename.


---------

Signed-off-by: Joachim Reichel <43646584+jreichel-nvidia@users.noreply.github.com>
@lgritz
Copy link
Collaborator

lgritz commented May 16, 2024

Was closed by #4263

@lgritz lgritz closed this as completed May 16, 2024
@jreichel-nvidia
Copy link
Contributor Author

Does this fix meet the requirements for a merge to the 2.5 branch?

lgritz pushed a commit to lgritz/OpenImageIO that referenced this issue May 18, 2024
…ation#4263) (AcademySoftwareFoundation#4264)

Add proxy support for EXR multipart output by taking the setup code from
the other open() overload and calling the constructor accepting a stream
instead of a filename.


---------

Signed-off-by: Joachim Reichel <43646584+jreichel-nvidia@users.noreply.github.com>
@lgritz
Copy link
Collaborator

lgritz commented May 20, 2024

Does this fix meet the requirements for a merge to the 2.5 branch?

@jreichel-nvidia Yes, certainly, it will be in the June 1 patch release.

lgritz pushed a commit to lgritz/OpenImageIO that referenced this issue May 20, 2024
…ation#4263) (AcademySoftwareFoundation#4264)

Add proxy support for EXR multipart output by taking the setup code from
the other open() overload and calling the constructor accepting a stream
instead of a filename.


---------

Signed-off-by: Joachim Reichel <43646584+jreichel-nvidia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants