-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenColorIO library CMakeLists.txt: Sets up GNUInstallDirs for non-win but completely ignores it in install(TARGETS... #1296
Comments
I see this is still a problem in 2.1.0. Hardcoding install paths is BAD. Here's my fix:
|
Thanks for the suggestion @hobbes1069, I implemented that, among other things, in #1471 would be great if you could have a look. |
LGTM! |
@hobbes1069 Would be curious if you have an example where the current hardcoded script fails or produce unexpected results, so that we are aware of what kind of changes we can expect for existing users? Thanks. |
Specifically in my case as a Fedora Linux packager, libraries go into either |
Thanks, that makes sense, I was expecting Windows differences related to the build configuration but forgot about these architecture issues. Agree that the less we hardcode the better, especially when CMake override are available. |
I reopened the issue because the pull request is not yet merged. |
OpenColorIO/src/OpenColorIO/CMakeLists.txt
Lines 181 to 193 in bc88857
and then:
OpenColorIO/src/OpenColorIO/CMakeLists.txt
Lines 297 to 301 in bc88857
Why go to the trouble of setting up the right directories and then just not use them?
The text was updated successfully, but these errors were encountered: