Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Secoundry YAxis Label Is Nor Showing Correctly #704

Closed
sandeep-synclovis opened this issue Jul 10, 2024 · 1 comment
Closed

In Secoundry YAxis Label Is Nor Showing Correctly #704

sandeep-synclovis opened this issue Jul 10, 2024 · 1 comment

Comments

@sandeep-synclovis
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-gifted-charts@1.4.7 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-gifted-charts/src/Components/BarAndLineChartsWrapper/renderHorizSections.tsx b/node_modules/react-native-gifted-charts/src/Components/BarAndLineChartsWrapper/renderHorizSections.tsx
index b8e020c..cfa24cc 100644
--- a/node_modules/react-native-gifted-charts/src/Components/BarAndLineChartsWrapper/renderHorizSections.tsx
+++ b/node_modules/react-native-gifted-charts/src/Components/BarAndLineChartsWrapper/renderHorizSections.tsx
@@ -199,7 +199,7 @@ export const renderHorizSections = (props: horizSectionPropTypes) => {
       let label = getLabelTextsForSecondaryYAxis(sectionItems.value, index);
       if (
         secondaryYAxisConfig.hideOrigin &&
-        index === secondaryHorizSections.length - 1
+        index === 0
       ) {
         label = '';
       }

This issue body was partially generated by patch-package.

@Abhinandan-Kushwaha
Copy link
Owner

Hi @sandeep-synclovis
Thanks for reporting this.
It has been fixed from version 1.4.17 onwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants