You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The CVODES constraint handling (see also #2327) would also allow us to enforce conservation laws, and probably make our code quite a bit simpler.
To be discussed whether we'd want to keep the current conservation law handling anyways in order to support other solver at some point, but it seems rather unlikely that this will happen.
This would also solve the currently missing/difficult handling of non-negativity constraints in combination with conservation laws.
This will, however, first require upgrading SUNDIALS (#1565).
Yes getting rid of the conservation laws would indeed be great. Is constraint handling also supported by the non-linear solvers? Moreover, we would have to figure out a way of applying the constraints when computing derivatives implicitly. Not an issue with positivity but more problematic with conservation laws.
The CVODES constraint handling (see also #2327) would also allow us to enforce conservation laws, and probably make our code quite a bit simpler.
To be discussed whether we'd want to keep the current conservation law handling anyways in order to support other solver at some point, but it seems rather unlikely that this will happen.
This would also solve the currently missing/difficult handling of non-negativity constraints in combination with conservation laws.
This will, however, first require upgrading SUNDIALS (#1565).
[1] Note: relevant memory leaks fixed in v6.4.0
The text was updated successfully, but these errors were encountered: