Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch all notification_emails together #1186

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Apr 5, 2024

No description provided.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 91.93548% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 98.46%. Comparing base (90477b3) to head (5bc8f41).
Report is 1 commits behind head on stable.

Files Patch % Lines
lib/applications.js 93.47% 3 Missing ⚠️
lib/middlewares.js 75.00% 1 Missing ⚠️
lib/positions.js 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           stable    #1186      +/-   ##
==========================================
- Coverage   98.71%   98.46%   -0.26%     
==========================================
  Files          38       38              
  Lines        2183     2213      +30     
  Branches      429      442      +13     
==========================================
+ Hits         2155     2179      +24     
- Misses         24       30       +6     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WikiRik WikiRik merged commit ac40171 into stable Apr 5, 2024
5 of 7 checks passed
@WikiRik WikiRik deleted the WikiRik/notification-email-improvements branch April 5, 2024 09:56
serge1peshcoff pushed a commit that referenced this pull request Apr 5, 2024
## [1.12.2](1.12.1...1.12.2) (2024-04-05)

### Bug Fixes

* fetch all notification_emails together ([#1186](#1186)) ([ac40171](ac40171))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 1.12.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants