Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.3.0 -- ESA CDSE cutover and timstamp fixes #157

Merged
merged 20 commits into from
Nov 16, 2023
Merged

Release v0.3.0 -- ESA CDSE cutover and timstamp fixes #157

merged 20 commits into from
Nov 16, 2023

Conversation

jhkennedy
Copy link
Collaborator

No description provided.

asjohnston-asf and others added 19 commits August 31, 2023 09:13
@jhkennedy jhkennedy added the patch Bump the patch version number of this project label Nov 16, 2023
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jhkennedy
jhkennedy commented Nov 16, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jhkennedy jhkennedy changed the title Release v0.2.6 -- ESA CDSE cutover and timstamp fixes Release v0.3.0 -- ESA CDSE cutover and timstamp fixes Nov 16, 2023
@cmarshak
Copy link
Collaborator

Questions:

  1. Are the tests failing because of issues with downloading?
  2. We have a big merge in Custom event #122 - should we wait to release those together or do them separately? Thinking that should be merged before turkey day? 🤞

@jhkennedy jhkennedy added minor Bump the minor version number of this project and removed patch Bump the patch version number of this project labels Nov 16, 2023
@jhkennedy
Copy link
Collaborator Author

  1. Are the tests failing because of issues with downloading?

Something threw a 504; I suspect it's transient and this round of checks to pass

  1. We have a big merge in Custom event #122 - should we wait to release those together or do them separately? Thinking that should be merged before turkey day? 🤞

I think we should get this out the door as soon as you're happy with these changes -- scihub orbits may shutdown at anytime so it'd be good to have already cut over.

Always better to release smaller, incremental changes faster :-D

@jhkennedy jhkennedy marked this pull request as ready for review November 16, 2023 17:55
cmarshak
cmarshak approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@cmarshak cmarshak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thank you, @jhkennedy, @asjohnston-asf, and @forrestfwilliams.

@jhkennedy jhkennedy merged commit 2ba6233 into main Nov 16, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmarshak cmarshak cmarshak approved these changes

Assignees
No one assigned
Labels
minor Bump the minor version number of this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jhkennedy @cmarshak @asjohnston-asf @jtherrmann @forrestfwilliams