Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed message html entities escaping when sending to Telegram #1855

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

sas1024
Copy link
Contributor

@sas1024 sas1024 commented Jun 29, 2022

Hello!

If you send message (for example, from Slack) with following content to Telegram:

I'm just <br /> unescaped html with ````<b>some</b> html```` inside code block

Message will be failed to to send with following error:
SendMessage failed: Bad Request: can't parse entities: Unsupported start tag "br" at byte offset

This PR just fixes this issue with Telegram messages sending with message MessageFormat="HTML".

@codeclimate
Copy link

codeclimate bot commented Jun 29, 2022

Code Climate has analyzed commit a9b5875 and detected 0 issues on this pull request.

View more on Code Climate.

@42wim 42wim added this to the 1.52.3 milestone Jul 6, 2022
@42wim 42wim added the telegram label Jul 6, 2022
@42wim 42wim merged commit 3c4192e into 42wim:master Jul 6, 2022
@42wim
Copy link
Owner

42wim commented Jul 6, 2022

Thanks!

@sas1024
Copy link
Contributor Author

sas1024 commented Jul 20, 2022

@42wim there is typo in milestone :) 1.52.3 -> 1.25.3

nightmared pushed a commit to nightmared/matterbridge that referenced this pull request Jul 23, 2022
nightmared pushed a commit to nightmared/matterbridge that referenced this pull request Jul 23, 2022
@42wim 42wim modified the milestones: 1.52.3, 1.26.0 Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants