Slack: Preserve threading for messages with files #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42wim
reviewed
Mar 30, 2022
|
Code Climate has analyzed commit 6e06f33 and detected 0 issues on this pull request. View more on Code Climate. |
|
Very nice, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow to preserve threading when Slack receive files.
I've tested it between Telegram and Slack, all work fine.
Old behavior: Send file From Telegram to Slack will produce file in Slack, but if I quote this file in Telegram and send message, this message will not received by Slack. If I reply to message with this file in Slack, Telegram message will be not attached as reply on message with file.
New behavior: Send file From Telegram to Slack will produce file in Slack, if I quote this file in Telegram and send message, this message will received by Slack. If I reply to message with this file in Slack, Telegram message will be attached as reply on message with file.