Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telegram: Multiple media in one message #1779

Merged
merged 6 commits into from
Mar 30, 2022

Conversation

sas1024
Copy link
Contributor

@sas1024 sas1024 commented Mar 28, 2022

In this PR:

  1. Fix for quoting when message have media with caption.
  2. Send message with multiple media as one message with media group.
  3. Preserve threading for telegram messages with files.

I've test this changes via Slack and Telegram.

Old behavior: Sending one message with 3 images/files from Slack produces 3 telegram messages with one image/file each.
New behavior: Sending one message with 3 images/files from Slack produces one telegram message with 3 images/files.

bridge/telegram/handlers.go Outdated Show resolved Hide resolved
bridge/telegram/handlers.go Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Mar 30, 2022

Code Climate has analyzed commit 9111eef and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@sas1024 sas1024 changed the title Telegram multiple media in one message Telegram: Multiple media in one message Mar 30, 2022
@42wim 42wim added the telegram label Mar 30, 2022
@42wim 42wim added this to the 1.25.0 milestone Mar 30, 2022
@42wim 42wim merged commit 30aae8e into 42wim:master Mar 30, 2022
@42wim
Copy link
Owner

42wim commented Mar 30, 2022

Also good job! 👍 thanks!

@sas1024 sas1024 deleted the telegram-multiple-images branch March 30, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants