Gather all names before printing them. #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When issuing a NAMES request, the reponse is chunked. Cache names until all are received, then print them out.
|
My Go experience is pretty much limited to my patches to this project. My array / slice handling here seems somewhat dysfunctional to me, any hints on how to improve this (or just fixing it) would be much appreciated. |
| @@ -25,6 +27,7 @@ func NewBridge(name string, config *Config) *Bridge { | |||
| b.Config = config | |||
| b.cmap = make(map[string]string) | |||
| b.ircNick = b.Config.IRC.Nick | |||
| b.names = make([]string, 0, 10000) | |||
There was a problem hiding this comment.
This is not necessary for our use case, we don't need to allocate this much. We can just use the append function to grow dynamically. (line can be removed)
|
Looks pretty good, I'm no expert myself though. |
|
@42wim thanks for the input. From the Go docs, it wasn't clear to me it could be done this way. Pushed now. :-) |
42wim
added a commit
that referenced
this pull request
Apr 11, 2022
42wim
added a commit
that referenced
this pull request
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When issuing a NAMES request, the reponse is chunked. Cache names
until all are received, then print them out.