[oidc] always get issuer/iss from the OIDC Discovery endpoint #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So later when the token is verified it can be exact match. Before the URL could be different due to some reverse proxies or credentials embedded in the URL.
mikz
force-pushed
the
oidc-unify-issuer
branch
from
ffe55dc
to
bca2062
Compare
davidor
approved these changes
Sep 5, 2018
|
Thank you @mikz :) Looks good! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So later when the token is verified it can be an exact match.
Before the URL could be different due to some reverse proxies or
credentials embedded in the URL.
/cc @mayorova