Fix tests that expect debug output without enabling the option #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…header is set This was setting the response debug headers even when the debug request header was not set in a specific case: when 'service.backend_authentication.value' is nil. This was happening in some integration tests. While at it, rename the `get_debug_value` method to a more appropriate name.
davidor
changed the title
mikz
approved these changes
Feb 6, 2018
mikz
approved these changes
Feb 6, 2018
mikz
deleted the
fix-tests-that-expect-debug-output-without-debug-headers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the tests that expect response debug headers to be set without enabling the debug option via headers.