[config] use LRU cache for configuration store #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new configuration always overrides the old one * if there is a service with some host and new one comes in it will override the original
so we can expire configuration after some timeout
mikz
force-pushed
the
configuration-store-lru
branch
from
3f06eeb
to
ecda438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important change here is when new configuration is loaded it overrides all existing configuration for those hosts.
When path routing is not enabled nothing really happens as there can be just one service for each host.
But when path routing is enabled and first you load two services for host 'a' and next time just one service for host 'a' it removes the first service. Which is more correct.