-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THREESCALE-9976 Fix GRPC #1419
THREESCALE-9976 Fix GRPC #1419
Conversation
05c59ca
to
b5c125a
Compare
Not sure why GH print the review twice 😕 |
@@ -22,11 +24,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
- In boot mode on `init_worker` check configuration expiration [PR #1399](https://github.com/3scale/APIcast/pull/1399) [THREESCALE-9003](https://issues.redhat.com/browse/THREESCALE-9003) | |||
- Removes the warning message at the bootstrap [PR #1398](https://github.com/3scale/APIcast/pull/1398) [THREESCALE-7942](https://issues.redhat.com/browse/THREESCALE-7942) | |||
- Set NGiNX variable variables_hash_max_size to 2048 to avoid startup warning [PR #1395](https://github.com/3scale/APIcast/pull/1395) [THREESCALE-7941](https://issues.redhat.com/browse/THREESCALE-7941) | |||
- Dev environment on aarch64 host [PR #1381](https://github.com/3scale/APIcast/pull/1381) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a small thing but I think this is an unrelated change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just the IDE tool removing trailing spaces
|
||
### Added | ||
|
||
- Doc: Policy Development Tutorial [PR #1384](https://github.com/3scale/APIcast/pull/1384) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just the IDE tool removing trailing spaces
Ignore my previous comment. just found this one openresty/lua-nginx-module#2172 |
From https://github.com/openresty/lua-nginx-module#ngxreqread_body
|
What
Fixes https://issues.redhat.com/browse/THREESCALE-9976
GRPC leverages the POST HTTP2 method (GRPC Spec) . APIcast reads the body looking for request params for POST based requests using ngx.req.read_body. However, ngx.req.read_body does not support HTTP2 and it blocks the request. The clients receive connection timeout errors.
Added development environment for GRPC scenario
Verification steps
cd dev-environments/grpc make gateway-certs make upstream-certs make gateway IMAGE_NAME=apicast-test
The command should return the echo response