Skip to content
This repository has been archived by the owner on Aug 9, 2021. It is now read-only.
This repository has been archived by the owner on Aug 9, 2021. It is now read-only.

when trying to getVerifiedAccounts on a profile created before 1.2.0 we get an error #258

Closed
tzapu opened this issue Jan 16, 2019 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@tzapu
Copy link

tzapu commented Jan 16, 2019

Describe the bug
When calling Box.getVerifiedAccounts(profile) on a profile created before 3box 1.2.0 that has no twitter/github identities, we get back an error no JWT passed into decodeJWT
screenshot 2019-01-16 12 16 46

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://jsfiddle.net/gnt39L2j/'
  2. Open Inspect/Console
  3. Check out the error

Expected behavior
Not to error

Screenshots
screenshot 2019-01-16 12 16 46

Desktop (please complete the following information):

  • OS: macOS
  • Browser chrome, safari
    Additional context
    Spoke on discord with @oed
@oed
Copy link
Member

oed commented Jan 16, 2019

Thanks for reporting!
This is because we assume that there is a proof_did property in getVerifiedAccounts. Have a fix coming up!

@tzapu
Copy link
Author

tzapu commented Jan 16, 2019

is there a release planned that includes this fix as well?

thanks for the super prompt response with this issue

/edit never mind, saw the pull request for 1.2.1, cheers

@oed
Copy link
Member

oed commented Jan 17, 2019

@tzapu 1.2.1 is now released :) https://github.com/3box/3box-js/releases

@tzapu
Copy link
Author

tzapu commented Jan 17, 2019

just wanted to confirm that this has sorted it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants