Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🟢 Make footnotes accessible across the site #323

Closed
Tracked by #381
, #376
...
echappen opened this issue May 24, 2022 · 2 comments
Closed
Tracked by #381
, #376
...

🟢 Make footnotes accessible across the site #323

echappen opened this issue May 24, 2022 · 2 comments
Labels
Engineering Task related to the Engineering Guide and/or pulled from the old Engineering Guide repo. Guides Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods"

Comments

@echappen
Copy link
Contributor

This pa11y issue appears to be an issue with jekyll's default markdown generator 🙈 see relevant pr here. it seems like it's a true accessibility bug with the way it's applying the role to the footnotes of the on-call pages.

solutions are:

  • ignore it for the moment, since hopefully it will be fixed soon (it looks like someone started paying attention to that bug today)
  • contribute???
  • something complex that involves not using the default footnotes ???
  • get rid of the footnotes and add the relevant details in-line with the rest of the text

Originally posted by @Sgtpluck in 18F/development-guide#310 (comment)
@christophermather christophermather transferred this issue from 18F/development-guide Dec 20, 2023
@christophermather christophermather added the Engineering Task related to the Engineering Guide and/or pulled from the old Engineering Guide repo. label Dec 20, 2023
This was referenced Dec 22, 2023
Closed
Open
@christophermather christophermather added Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods" Guides labels Dec 22, 2023
@amymok amymok changed the title Make footnotes accessible across the site 🟢 Make footnotes accessible across the site Jan 11, 2024
@bpdesigns
Copy link
Member

@cantsin checking to see if you think this work is still valid or outdated

@cantsin
Copy link
Member

cantsin commented May 17, 2024

We aren't using Jekyll anymore. Closing.

@cantsin cantsin closed this as completed May 17, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Engineering Task related to the Engineering Guide and/or pulled from the old Engineering Guide repo. Guides Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods"
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cantsin @echappen @bpdesigns @christophermather