Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 404 not found responses consistent #99

Closed
GUI opened this issue Jul 25, 2014 · 1 comment
Closed

Make 404 not found responses consistent #99

GUI opened this issue Jul 25, 2014 · 1 comment

Comments

@GUI
Copy link
Member

GUI commented Jul 25, 2014

Depending on where you hit in the site, you may get a different 404 experience:

The reason for these differences has to do with how we route API requests vs web page requests differently (see this comment for more details).

I think ideally we want these not found experiences to be consistent, and preferably the prettier one for web site users.

This is achievable in a variety of different ways, but one way might be to configure API Umbrella's errors (currently the ugly ones) to use the pretty template when returning HTML error responses (since web browser users should get the HTML responses based on API Umbrella's content negotiation).

@GUI
Copy link
Member Author

GUI commented Mar 30, 2015

This was fixed by the routing improvements made in #146 Now both of those example URLs will result in the more friendly not found page. More generally, any URL that's not part of a known API will get routed to the website content where we can deliver more friendly error pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant