Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "contactUrl" option for signup form not working for certain external sites #497

Closed
GUI opened this issue Apr 25, 2019 · 1 comment
Closed

Comments

@GUI
Copy link
Member

GUI commented Apr 25, 2019

As a result of the changes made in #460 (comment), we sanitize the contactUrl setting used in the API key signup form against known API and website URLs. However, this has broken some agencies that were previously linking to things like the github.com issue tracker. In those cases, it's replacing the contact link with our default api.data.gov contact page, so there's still a link, but we want to ensure users are getting routed to the appropriate place for the agency. So we need some other way to whitelist other valid contact URLs beyond just URLs known to our system.

@mgwalker
Copy link
Member

mgwalker commented Dec 8, 2021

Closing as stale, on the assumption that the need will resurface if it still exists.

@mgwalker mgwalker closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants