Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request URLs with UTF-8 characters in them failing to be logged for analytics #198

Closed
GUI opened this issue Mar 9, 2015 · 1 comment
Closed

Comments

@GUI
Copy link
Member

GUI commented Mar 9, 2015

Due to the semi-recent changes in how we gather the logs for analytics processing, URLs containing UTF-8 characters were failing to be properly logged. So, for example, if you had a URL containing "?utf8=✓", the request would work just fine, but our background processing to log that in our analytics db was failing. This was due to how nginx escapes and logs special characters.

Surprisingly, this hasn't actually affect much of our traffic. It's only been cropping up in our error logs a few times a day, but it's still definitely something we want to fix.

@GUI GUI added this to the Sprint 16 (2/23-3/6) milestone Mar 9, 2015
@GUI GUI self-assigned this Mar 9, 2015
@GUI
Copy link
Member Author

GUI commented Mar 9, 2015

Fixed by NREL/api-umbrella-router@673ca14 I've added tests to ensure that a variety of weird URL encodings get logged properly. And while there weren't any issues with proxying these URLs containing utf8 characters, I've also added additional sanity check tests just to verify that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant