Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in datasift macos fixes #12

Closed
benjamg opened this issue Apr 3, 2013 · 1 comment
Closed

Pull in datasift macos fixes #12

benjamg opened this issue Apr 3, 2013 · 1 comment

Comments

@benjamg
Copy link
Member

benjamg commented Apr 3, 2013

@glaude made the following changes to support OSx MeltwaterArchive@ed2c07e

These work although really the POLL_IN / POLL_OUT constants should be replaced because POLL_IN and POLL_OUT are both fairly common macros and I have no idea what I was thinking when I used them. Surprised it works anywhere.

This will of course break backwards compatibility

@dkick
Copy link

dkick commented May 17, 2013

I really really really don't understand why people continue to SCREAM_THE_NAMES_OF_CONSTANTS like we're all still using the C preprocessor ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants