Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the ability to skip downloading compact blocks that have no shielded inputs or outputs. #457

Open
nuttycom opened this issue Sep 19, 2023 · 2 comments
Assignees

Comments

@nuttycom
Copy link
Contributor

Compact blocks that contain no shielded inputs or outputs do not cause any updates to wallet state. On testnet, purely-transparent blocks are very common, but wallets still have to download all of these compact blocks even though they can have no effect. When using the compact block protocol, it would be completely fine to skip all such blocks (doing so reveals no information, because every wallet using the compact block protocol would do so if possible), so lightwalletd should provide a way for wallets to entirely filter out these blocks and never download them.

@LarryRuane LarryRuane self-assigned this Sep 19, 2023
@LarryRuane
Copy link
Collaborator

Sounds like an easy and useful change. You say "should provide a way", so should we make this change backward-compatible? Don't provide these blocks only if explicitly asked not to (but otherwise behave the same as today)?

@nuttycom
Copy link
Contributor Author

Yeah, we probably need this to be backwards compatible. If we just start skipping blocks entirely it'll foul up a bunch of stuff. Also we need to figure out how to handle issues around chain continuity before we move forward with implementation; I just created this ticket so that I wouldn't forget about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants