Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing benches and other points in Outdoor #677

Open
kudlav opened this issue Oct 13, 2024 · 1 comment
Open

Missing benches and other points in Outdoor #677

kudlav opened this issue Oct 13, 2024 · 1 comment

Comments

@kudlav
Copy link
Contributor

kudlav commented Oct 13, 2024

Outdoor style and source contains benches and other pois that are not displayed on map.

When I change 'icon-image': 'bench', to 'icon-image': 'bench_11',, it's displayed on the map but it's not a clickable POI and it's quite blurry like raster image not vector image.

'icon-image': 'bench',

image

When searching for Bench category, benches are displayed correctly:
image
https://osmapp.org/node/11015285006#18.42/49.2206/16.5992

I can't find the code or style for the clickable objects to fix that.

@zbycz
Copy link
Owner

zbycz commented Oct 17, 2024

Hi, good point. I thougt it was showing some time before :)

I think in maplibre-gl all images are always raster (we use this sprite), the blurryness could be caused by scaling the icon. Currently it is set to 0.7 in some in zoom <20. I think we can live with that, but proper solution would be to generate a smaller icon and replace the two icons based on the zoom.

Clickabilty is decided on several factors and the code is quite old and messy. The condition is here and hover state is toggled here.

You can open a PR which will be merged quickly, but in some point in future it will be probably overwritten by upgrading to Outdoor-v2 (#444).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants