From 7bd4e890cede7b102439362d4d503f536da87b9d Mon Sep 17 00:00:00 2001 From: Niklas Neugebauer <68709968+NiklasNeugebauer@users.noreply.github.com> Date: Thu, 26 Sep 2024 16:23:04 +0200 Subject: [PATCH] Make image history length configurable (#202) * feat: reduce default number of images stored in `Camera` to 4 * replace MAX_IMAGES with a default parameter * Update rosys/vision/camera/camera.py Co-authored-by: Falko Schindler * dont save image_history_length --------- Co-authored-by: Pascal Schade Co-authored-by: Pascal Schade <165774906+pascalzauberzeug@users.noreply.github.com> Co-authored-by: Falko Schindler --- rosys/vision/camera/camera.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rosys/vision/camera/camera.py b/rosys/vision/camera/camera.py index 8b3757c7..087dbd6c 100644 --- a/rosys/vision/camera/camera.py +++ b/rosys/vision/camera/camera.py @@ -16,7 +16,6 @@ class Camera(abc.ABC): - MAX_IMAGES = 256 def __init__(self, *, @@ -26,12 +25,13 @@ def __init__(self, streaming: bool = True, polling_interval: float = 0.1, base_path_overwrite: str | None = None, + image_history_length: int = 256, **kwargs) -> None: super().__init__(**kwargs) self.id: str = id self.name = name or self.id self.connect_after_init = connect_after_init - self.images: deque[Image] = deque(maxlen=self.MAX_IMAGES) + self.images: deque[Image] = deque(maxlen=image_history_length) self.base_path: str = f'images/{base_path_overwrite or id}' self.should_stream: bool = streaming @@ -94,6 +94,7 @@ def to_dict(self) -> dict: 'name': self.name, 'connect_after_init': self.connect_after_init, 'streaming': self.should_stream, + 'image_history_length': self.images.maxlen, } @classmethod