Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getitems follow up work #1442

Open
jakirkham opened this issue Jun 22, 2023 · 1 comment
Open

getitems follow up work #1442

jakirkham opened this issue Jun 22, 2023 · 1 comment

Comments

@jakirkham
Copy link
Member

PR ( #1131 ) added getitems

In looking over the code we noticed some things that could benefit from cleanup

This check shouldn't be needed:

and hasattr(self.chunk_store, "getitems")

Also this PR ( #1040 ) might be worth reviewing to see if any pieces from it can be included

@jakirkham
Copy link
Member Author

cc @madsbk (for vis)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant