Fixes for initialization of heated seats #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test for the case where it broke before where the data isn't initialized yet? |
|
We're close to pushing a new release to address the login errors. Any chance to get that test in place so I can merge this too? |
|
Sorry for the delayed reply. I think the changes I made on 47e5f23 in test_heated_seat.py (line 33) address this. It's the same approach used by the initialization tests for the other components. |
|
I mean do we have a test in place to make sure we don't get the exception on startup #186 ? In theory after your fixes, you won't get the exception but this is to prevent a regression in the future. |
|
The test I reference would catch that. If anything sets the car state during initialization that assertion will fail. |
|
Ok. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #186