fix: fix give up condition for command retries

Commands will no longer retry if we needs user interaction
(e.g., bad credentials)

teslajsonpy/controller.py

@@ -25,7 +25,7 @@
     ONLINE_INTERVAL,
     SLEEP_INTERVAL,
 )
-from teslajsonpy.exceptions import RetryLimitError, TeslaException
+from teslajsonpy.exceptions import should_giveup, RetryLimitError, TeslaException
 from teslajsonpy.homeassistant.battery_sensor import Battery, Range
 from teslajsonpy.homeassistant.binary_sensor import (
     ChargerConnectionSensor,
@@ -496,7 +496,12 @@ async def data_request(self, car_id, name, wake_if_asleep=False):
         )["response"]
 
     @backoff.on_exception(
-        min_expo, TeslaException, max_time=60, logger=__name__, min_value=15
+        min_expo,
+        TeslaException,
+        max_time=60,
+        logger=__name__,
+        min_value=15,
+        giveup=should_giveup,
     )
     async def command(self, car_id, name, data=None, wake_if_asleep=True):
         """Post name command to the car_id.

teslajsonpy/exceptions.py

@@ -63,3 +63,23 @@ class UnknownPresetMode(TeslaException):
     """Class of exceptions for Unknown Preset."""
 
     pass
+
+
+def should_giveup(ex: TeslaException) -> bool:
+    """Test whether the exception should result in a retry.
+
+    This is consumed by backoff.
+
+    Args
+        ex (TeslaException): The exception
+
+    Returns
+        bool: whether backoff should give up
+
+    """
+    return isinstance(ex, (IncompleteCredentials, RetryLimitError)) or ex.code in [
+        401,
+        404,
+        405,
+        423,
+    ]