-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DatePicker): support confirm and getSelectedDate method #12762
feat(DatePicker): support confirm and getSelectedDate method #12762
Conversation
|
||
| Name | Description | Attribute | Return value | | ||
| --- | --- | --- | --- | | ||
| confirm | Stop scrolling and emit confirm event | - | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs has no return value, but the confirm method has.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know confirm method has no return value..
return pickerRef.value?.confirm(); | ||
}; | ||
|
||
const getSelectedDate = (): Array<string> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type of getSelectedDate can be inferred by ts, maybe no need to declare the return type.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12762 +/- ##
==========================================
+ Coverage 89.76% 89.80% +0.03%
==========================================
Files 257 257
Lines 6850 6856 +6
Branches 1663 1663
==========================================
+ Hits 6149 6157 +8
+ Misses 375 373 -2
Partials 326 326 ☔ View full report in Codecov by Sentry. |
youzan#12762) Co-authored-by: neverland <jait.chen@foxmail.com>
issue:#12711
为 DatePicker 组件添加了 confirm 方法
为 DatePicker 组件添加了 getSelectedDate 方法