Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] element-newline incorrectly reports on siblings #210

Closed
RobertAKARobin opened this issue Aug 6, 2024 · 3 comments · May be fixed by WontonSam/godot#21 or WontonSam/godot#22
Closed

[Bug] element-newline incorrectly reports on siblings #210

RobertAKARobin opened this issue Aug 6, 2024 · 3 comments · May be fixed by WontonSam/godot#21 or WontonSam/godot#22

Comments

@RobertAKARobin
Copy link
Contributor

RobertAKARobin commented Aug 6, 2024

For example, this test fails. It should pass because b and c are skipped:

    {
      code: `<a>
<b></b><c></c>
</a>`,
      options: [
        {
          skip: ["b", "c"]
        }
      ]
    }
@RobertAKARobin RobertAKARobin changed the title [Bug] element-newline incorrectly reports on multiple root-level elements [Bug] element-newline incorrectly reports on siblings Aug 6, 2024
@RobertAKARobin
Copy link
Contributor Author

Actually this seems to be a bug with checking sibling elements in general. Updated the main post.

@yeonjuan
Copy link
Owner

yeonjuan commented Aug 8, 2024

Hi @RobertAKARobin

This rule has an object option:
"skip": skips newline checking for the specified element's children

This seems not a bug. The skip option skips checking children's newlines of the specified tag.

@RobertAKARobin
Copy link
Contributor Author

This additional functionality added in #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants