From 952917f653ac9e9d283990a3efa6bc71930b7857 Mon Sep 17 00:00:00 2001 From: YeonJuan Date: Thu, 2 Nov 2023 01:26:41 +0900 Subject: [PATCH] feat: skip check when html tag does not exists (#154) --- .../lib/rules/require-doctype.js | 5 ++- .../tests/rules/require-doctype.test.js | 31 +++---------------- 2 files changed, 9 insertions(+), 27 deletions(-) diff --git a/packages/eslint-plugin/lib/rules/require-doctype.js b/packages/eslint-plugin/lib/rules/require-doctype.js index 33100be3..c6dd1a06 100644 --- a/packages/eslint-plugin/lib/rules/require-doctype.js +++ b/packages/eslint-plugin/lib/rules/require-doctype.js @@ -34,7 +34,10 @@ module.exports = { Doctype() { hasDocType = true; }, - "Program:exit"(node) { + "Tag:exit"(node) { + if (node.name !== "html") { + return; + } if (!hasDocType) { context.report({ node, diff --git a/packages/eslint-plugin/tests/rules/require-doctype.test.js b/packages/eslint-plugin/tests/rules/require-doctype.test.js index 79c5cb27..035791f1 100644 --- a/packages/eslint-plugin/tests/rules/require-doctype.test.js +++ b/packages/eslint-plugin/tests/rules/require-doctype.test.js @@ -12,6 +12,11 @@ ruleTester.run("require-doctype", rule, { `, }, + { + code: ` +
+ `, + }, ], invalid: [ { @@ -23,32 +28,6 @@ ruleTester.run("require-doctype", rule, { `, - errors: [ - { - messageId: "missing", - }, - ], - }, - { - code: ` - -`, - output: ` - - -`, - - errors: [ - { - messageId: "missing", - }, - ], - }, - { - code: ``, - output: ` -`, - errors: [ { messageId: "missing",