Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected node_modules when installing Bower dependencies #715

Closed
tony19 opened this issue Oct 11, 2016 · 2 comments
Closed

Unexpected node_modules when installing Bower dependencies #715

tony19 opened this issue Oct 11, 2016 · 2 comments

Comments

@tony19
Copy link

tony19 commented Oct 11, 2016

Bug

Running yarn on a project that only has a bower.json (no package.json) results in both bower_components/ and node_modules/.

bower.json:

{
  "name": "polymer-starter-kit",
  "authors": [
    "The Polymer Authors"
  ],
  "private": true,
  "dependencies": {
    "app-layout": "PolymerElements/app-layout#^0.10.0",
    "app-route": "PolymerElements/app-route#^0.9.0",
    "iron-flex-layout": "PolymerElements/iron-flex-layout#^1.0.0",
    "iron-icon": "PolymerElements/iron-icon#^1.0.0",
    "iron-iconset-svg": "PolymerElements/iron-iconset-svg#^1.0.0",
    "iron-localstorage": "PolymerElements/iron-localstorage#^1.0.0",
    "iron-media-query": "PolymerElements/iron-media-query#^1.0.0",
    "iron-pages": "PolymerElements/iron-pages#^1.0.0",
    "iron-selector": "PolymerElements/iron-selector#^1.0.0",
    "paper-icon-button": "PolymerElements/paper-icon-button#~1.1.0",
    "polymer": "Polymer/polymer#^1.6.0",
    "neon-animation": "^1.2.4"
  },
  "devDependencies": {
    "web-component-tester": "^4.0.0"
  }
}

The resulting node_modules/ directory contains:

$ ls node_modules 
sinon-chai

Steps to reproduce

  1. Copy the bower.json contents above into a local file.
  2. Run yarn (version 0.15.1).

Expected behavior

Only bower_components/ installed when yarn is run

Versions

  • node.js 6.7.0
  • macOS Sierra 10.12
  • yarn 0.15.1
@tony19
Copy link
Author

tony19 commented Oct 25, 2016

Workaround:

yarn install --modules-folder bower_components

@wyze
Copy link
Member

wyze commented Oct 26, 2016

Bower support has been dropped in #1441.

@wyze wyze closed this as completed Oct 26, 2016
@wyze wyze added invalid and removed needs triage labels Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants