Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic fetching of latest xbs-api and services + npm build error fix #23

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

steccas
Copy link

@steccas steccas commented Dec 10, 2021

Hi, I tought to send this PR because I noted the probles that I've reported with issues #21 and #22 .

The build is now smooth and clean and keeping the xbs api updated is now easier.

@nero120
Copy link
Member

nero120 commented Dec 20, 2021

Thank you for this @steccas, looks great! I've very little free time at the moment but will review this soon.

@steccas
Copy link
Author

steccas commented Dec 21, 2021

Thanks @nero120, please bear in mind that the fact that the dockerfile grabs the latest xbs version has some implications.

So maybe we can consider some CI/CD that keeps the image on the HUB updated, like running a build on a new release of xbs or maybe just scheduling. (like I did in my repo with github actions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants