Place a floor of 1 on the rate limit burst to prevent x/time from throwing an error #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owing an error. If GitLab is enforcing rate limits of fewer than 3 per second the existing logic will set burst to zero (it multiples the per-second value by 0.33 and then casts to int). rate.Limiter.Wait will fail if burst is zero with the message here: https://github.com/golang/time/blob/b24d3b5e50f7b0e18486d18f0a240d04d254ea73/rate/rate.go#L257 As Wait falls back to WaitN with n=1: https://github.com/golang/time/blob/b24d3b5e50f7b0e18486d18f0a240d04d254ea73/rate/rate.go#L231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If GitLab is enforcing rate limits of fewer than 3 per second the existing logic will set burst to zero (it multiplies the per-second value by 0.33 and then casts to int).
rate.Limiter.Waitwill fail if burst is zero becauseWaitfalls back toWaitNwith n=1: