Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop environment endpoint has a force option, how to introduce it to go-gitlab? #1836

Closed
inputvalidation opened this issue Nov 11, 2023 · 2 comments · Fixed by #1849
Closed

Stop environment endpoint has a force option, how to introduce it to go-gitlab? #1836

inputvalidation opened this issue Nov 11, 2023 · 2 comments · Fixed by #1849

Comments

@inputvalidation
Copy link
Contributor

https://docs.gitlab.com/ee/api/environments.html#stop-an-environment has a "force" option which is currently not exposed in go-gitlab. I'm happy to submit a PR but unsure if I can introduce this and maintain backwards compatibility with the existing function signature.

Any pointers on how the project would like to see this get implemented?
@svanharmelen
Copy link
Member

I see... We need to introduce an option struct for this... I'm OK to make a breaking change for this, so feel free to create a PR.

@inputvalidation inputvalidation mentioned this issue Dec 8, 2023
Merged
@inputvalidation
Copy link
Contributor Author

@svanharmelen I have created the PR, let me know what you think :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@svanharmelen @inputvalidation