Fix type of ExpiresAt field

xanzy · Apr 3, 2024 · f0156f0 · f0156f0
1 parent be6bc9f
commit f0156f0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/group_serviceaccounts.go b/group_serviceaccounts.go
@@ -64,7 +64,7 @@ func (s *GroupsService) CreateServiceAccount(gid interface{}, options ...Request
 type CreateServiceAccountPersonalAccessTokenOptions struct {
 	Scopes    *[]string `url:"scopes,omitempty" json:"scopes,omitempty"`
 	Name      *string   `url:"name,omitempty" json:"name,omitempty"`
-	ExpiresAt *string   `url:"expires_at,omitempty" json:"expires_at,omitempty"`
+	ExpiresAt *ISOTime  `url:"expires_at,omitempty" json:"expires_at,omitempty"`
 }
 
 // CreateServiceAccountPersonalAccessToken add a new Personal Access Token for a

diff --git a/group_serviceaccounts_test.go b/group_serviceaccounts_test.go
@@ -18,6 +18,7 @@ package gitlab
 
 import (
 	"fmt"
+	"github.com/stretchr/testify/require"
 	"net/http"
 	"reflect"
 	"testing"
@@ -72,10 +73,14 @@ func TestCreateServiceAccountPersonalAccessToken(t *testing.T) {
       	"token":"random_token"
       }`)
 	})
+
+	expireTime, err := ParseISOTime("2024-06-12")
+	require.NoError(t, err)
+
 	options := &CreateServiceAccountPersonalAccessTokenOptions{
 		Scopes:    Ptr([]string{"api"}),
 		Name:      Ptr("service_account_token"),
-		ExpiresAt: Ptr("2024-06-12"),
+		ExpiresAt: Ptr(expireTime),
 	}
 	pat, _, err := client.Groups.CreateServiceAccountPersonalAccessToken(1, 57, options)
 	if err != nil {