Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation error in HTML mode after modifying a html tag #1570

Closed
malinajirka opened this issue Nov 12, 2019 · 3 comments
Closed

Validation error in HTML mode after modifying a html tag #1570

malinajirka opened this issue Nov 12, 2019 · 3 comments
Assignees
Labels

Comments

@malinajirka
Copy link
Contributor

malinajirka commented Nov 12, 2019

Describe the bug
When I replace a valid tag in HTML mode with an invalid tag gutenberg displays validation error -> eg <p> with <p123>.

To Reproduce
Steps to reproduce the behavior:

  1. Create a post in WPAndroid
  2. Type "hello"
  3. Switch to HTML
  4. Edit <p> to <p123>
  5. Click on title
  6. Boom

Expected behavior
The app won't crash.

Screenshots
crash-gb

Smartphone (please complete the following information):

  • Device: Emulator
  • OS: Android API 29
  • Version develop - 6e59663f8c0eda962c8a6fa0a45212fbd17942b1
@cameronvoell cameronvoell self-assigned this Dec 13, 2019
@cameronvoell
Copy link
Contributor

As I'm working on this, I just wanted to comment that since the exhibited behavior is actually a Block Validation error (which only show the red banner in develop mode) and not a crash, the behavior for users will not be a full fledged crash, but will actually show disappearing paragraph HTML (the invalid block still shows in visual mode) . There is still something interesting going on here that should be fixed, but it might not have the urgency expressed in the title of this issue, since it is not actually crashing for users. See behavior in non develop build in the following video.

html-error

@malinajirka malinajirka changed the title Crash in HTML mode after modifying a html tag Validation error in HTML mode after modifying a html tag Jan 13, 2020
@Tug
Copy link
Contributor

Tug commented Jan 27, 2020

@geriux
Copy link
Contributor

geriux commented May 14, 2024

I'm closing this PR due to its activity. Currently, there's no easy option to toggle between editors and now if you change the HTML markup and it's detected as invalid, the editor will show a placeholder with an option to attempt to recover it.

Please feel free to re-open it if we happen to get any user reports about it. Thanks!

@geriux geriux closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done (keep clean, manually)
Development

No branches or pull requests

5 participants