Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node x version break #12

Open
sydonia86 opened this issue Aug 28, 2023 · 3 comments
Open

Node x version break #12

sydonia86 opened this issue Aug 28, 2023 · 3 comments

Comments

@sydonia86
Copy link

This is a follow-up to #10, because my team is still having issues.

Lowering the required node version to 14 didn't solve our problem, because the oldest active branch of our product is using an even older node version.
Yes, I know. Old version bad. But as long as we have customers that don't wish to upgrade, we have to continue supporting said product version.

Anyway, none of that should matter. Semantic versioning exists to prevent these types of issues, but it only does so when used properly. That means bumping the major version when introducing breaking changes. And reducing the subset of supported node versions is definitely a breaking change.

Thanks for your time 🙏

@FrKan
Copy link

FrKan commented Sep 20, 2023

Hi, many packages like winston using this package. There are many legacy project using older Node versions. In our one of legacy project which uses Node 6 fails while installing packages. Because many of them using triple-beam as "^1.3.0". I tried fork and update versions of packages and their nested packages and their nested packages but it looks like i need work more. :)
I think that adding least node version major update for different packages thats why it brokes many projects. Is it possible to change least node version and release new triple-beam version. Or is there any different solution?

@a-samad
Copy link

a-samad commented Nov 3, 2023

It is breaking for older Node versions (6.17.x)
node_modules/.staging/@types/triple-beam-0d4a3565/package.json
What is the solution here?

@shammalie
Copy link

I've commented before: #10 (comment)
Moving/supporting to Node14 should be considered a major release as the changes made causes older node versions to not work any more with this package, and winston.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants