-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the importance of DDIM? #96
Comments
Thank you for your interest. Almost not important. Rerender_A_Video/src/ddim_v_hacked.py Lines 322 to 323 in fcb7431
We have two latent So I rescale the These two points are where we use the DDIM. For other parts, I think DDIM is not important. |
I am working on integrating this repository with ComfyUI, so this project can get support for ControlNet, LoRA, etc. all for free from ComfyUI's infrastructure.
The main issue is, I need to understand exactly how the DDIM sampler was hacked.
From reading the paper, it looks like it was patched to support cross-frame attention.
This makes me guess that DDIM is not of importance here. i.e., the standard diffusion schedule could be used as well if it was patched. Is this an incorrect assumption?
The text was updated successfully, but these errors were encountered: