From 65d63f2704817b85de4f14a2c58971e3d6392715 Mon Sep 17 00:00:00 2001 From: Anne van Kesteren Date: Fri, 16 Aug 2019 15:42:13 +0200 Subject: [PATCH 1/3] Remove progress events It seems this feature got added without an agreed upon plan. Firefox fires the loadstart event, but I cannot find evidence of the other events or them using the correct class. Tests: ... Closes #1915. Closes #3860. --- source | 86 +++++++++------------------------------------------------- 1 file changed, 13 insertions(+), 73 deletions(-) diff --git a/source b/source index 3f7f80198fd..0bed659169f 100644 --- a/source +++ b/source @@ -3437,7 +3437,6 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
  • ProgressEvent.lengthComputable attribute
  • ProgressEvent.loaded attribute
  • ProgressEvent.total attribute
    • -
  • Fire a progress event named e
  • FormData interface
  • FormDataEntryValue @@ -27876,11 +27875,6 @@ was an English <a href="/wiki/Music_hall">music hall</a> singer, ...

    Abort the update the image data algorithm.

    • - - @@ -27920,15 +27914,11 @@ was an English <a href="/wiki/Music_hall">music hall</a> singer, ...uses srcset or picture, fire an event named error at the img element.

    -

  • ⌛ Return.

    • -

  • ⌛ Queue a task to fire a progress event named loadstart at the img element.

    • -

  • ⌛ Parse selected source, relative to the element's node document, and let urlString be the resulting URL @@ -27946,8 +27936,7 @@ was an English <a href="/wiki/Music_hall">music hall</a> singer, ...

    ⌛ Queue a task to change the current request's current URL to selected source, fire an event named error - at the img element and then fire an event - named loadend at the img element.

    • + at the img element.

  • ⌛ Return.

    • @@ -28015,12 +28004,6 @@ was an English <a href="/wiki/Music_hall">music hall</a> singer, ...cross-origin access control policies that are stricter than those described above to mitigate this attack, but unfortunately such policies are typically not compatible with existing Web content.

    - -

    If the resource is CORS-same-origin, each task - that is queued by the networking task source - while the image is being fetched, if image request is the current - request, must fire a progress event named progress at the img element.

  • End the synchronous section, continuing the remaining steps in @@ -28085,11 +28068,6 @@ was an English <a href="/wiki/Music_hall">music hall</a> singer, ...load at the img element.

    - -

    The progress and loadend events are not fired for - multipart/x-mixed-replace image streams.

    -
    If the resource type and data corresponds to a supported image format, music hall</a> singer, ... for the current request and the pending request, upgrade the pending request to the current request, set current request's state to broken, fire an event - named error at the img element, fire an event named loadend at the img element.

    • - -
  • - -

    Otherwise, if the user agent is able to determine that image request's image - is corrupted in some fatal way such that the image dimensions cannot be obtained, and - image request is current request, abort the image - request for image request, fire an - event named error at the img element, - fire an event named loadend at the img element.

    - -
    • + data-x="img-error">broken, and fire an event + named error at the img element.

    +

  • Otherwise, if the user agent is able to determine that image request's + image is corrupted in some fatal way such that the image dimensions cannot be obtained, and + image request is current request, abort the image + request for image request and fire an + event named error at the img + element.

    • That task, and each subsequent music hall</a> singer, ...

    Add the image to the list of available images using the key key, with the ignore higher-layer caching flag set.

    -

  • Fire a progress event or event named load - at the img element, depending on the resource in image request.

    • - -

  • Fire a progress event or event named loadend - at the img element, depending on the resource in image request.

    • - +

  • Fire an event named load at the + img element.

    • -
    Otherwise
    @@ -28185,10 +28150,8 @@ was an English <a href="/wiki/Music_hall">music hall</a> singer, ...broken, abort the image request for the current request and the pending request, upgrade the pending request to the current request if image request is the pending request, and - then queue a task to first fire an event - named error at the img element and then fire an event named loadend at the img element.

    + then queue a task to fire an event named + error at the img element.

    @@ -28218,11 +28181,6 @@ was an English <a href="/wiki/Music_hall">music hall</a> singer, ... -

    To fire a progress event or event named type at an element e, - depending on resource r, means to fire a progress event named - type at e if r is CORS-same-origin, and otherwise - fire an event named type at e.

    -
    Selecting an image source
    @@ -122808,18 +122766,6 @@ INSERT INTERFACES HERE Window, elements Fired at the Window when the document has finished loading; fired at an element containing a resource (e.g. img, embed) when its resource has finished loading - - loadend - Event or ProgressEvent - img elements - Fired at img elements after a successful load - - - loadstart - ProgressEvent - img elements - Fired at img elements when a load begins (see also media element events) - message MessageEvent @@ -122875,12 +122821,6 @@ INSERT INTERFACES HERE Window Fired at the Window when the user navigates the session history - - progress - ProgressEvent - img elements - Fired at img elements during a CORS-same-origin image load (see also media element events) - readystatechange Event From 79391d4b35067e5b5ad6a155aa3b3da9133f080e Mon Sep 17 00:00:00 2001 From: Anne van Kesteren Date: Fri, 16 Aug 2019 15:56:56 +0200 Subject: [PATCH 2/3] also remove onloadend (media does not use it and neither Chrome/Safari have it) --- source | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/source b/source index 0bed659169f..fb86ee6eda3 100644 --- a/source +++ b/source @@ -28138,8 +28138,8 @@ was an English <a href="/wiki/Music_hall">music hall</a> singer, ...

    Add the image to the list of available images using the key key, with the ignore higher-layer caching flag set.

    -

  • Fire an event named load at the - img element.

    • +

  • Fire an event named load at the img element.

    • @@ -92639,7 +92639,6 @@ typedef OnBeforeUnloadEventHandlerNonNull? OnBeforeUnloadEvent onkeyup keyup onloadeddata loadeddata onloadedmetadata loadedmetadata - onloadend loadend onloadstart loadstart onmousedown mousedown onmouseenter mouseenter @@ -121897,12 +121896,6 @@ interface External { loadedmetadata event handler Event handler content attribute - - onloadend - HTML elements - loadend event handler - Event handler content attribute - onloadstart HTML elements From 4c754186cf97c52fc21ee6a3389f979ecb45fa1e Mon Sep 17 00:00:00 2001 From: Anne van Kesteren Date: Fri, 16 Aug 2019 16:04:20 +0200 Subject: [PATCH 3/3] thank you CI --- source | 2 -- 1 file changed, 2 deletions(-) diff --git a/source b/source index fb86ee6eda3..9795d58bf97 100644 --- a/source +++ b/source @@ -11677,7 +11677,6 @@ https://software.hixie.ch/utilities/js/live-dom-viewer/?%3C%21DOCTYPE%20HTML%3E%
  • onload*
  • onloadeddata
  • onloadedmetadata
    • -
  • onloadend
  • onloadstart
  • onmousedown
  • onmouseenter
    • @@ -92820,7 +92819,6 @@ typedef OnBeforeUnloadEventHandlerNonNull? OnBeforeUnloadEvent attribute EventHandler onload; attribute EventHandler onloadeddata; attribute EventHandler onloadedmetadata; - attribute EventHandler onloadend; attribute EventHandler onloadstart; attribute EventHandler onmousedown; [LenientThis] attribute EventHandler onmouseenter;