From f694bbac598345f23b9c63d9375054d58b6eff96 Mon Sep 17 00:00:00 2001 From: Louis Thibault Date: Wed, 9 Nov 2022 15:07:01 -0500 Subject: [PATCH] Add topic field to Undeliverable/Reject logs from Tracer. --- pkg/pubsub/tracer.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/pkg/pubsub/tracer.go b/pkg/pubsub/tracer.go index 5ff6080f..f73ec8bc 100644 --- a/pkg/pubsub/tracer.go +++ b/pkg/pubsub/tracer.go @@ -78,8 +78,9 @@ func (t Tracer) DeliverMessage(*pubsub.Message) { // RejectMessage is invoked when a message is Rejected or Ignored. // The reason argument can be one of the named strings Reject*. -func (t Tracer) RejectMessage(_ *pubsub.Message, reason string) { +func (t Tracer) RejectMessage(m *pubsub.Message, reason string) { t.Log. + WithField("topic", m.GetTopic()). WithField("reason", reason). Info("message rejected") t.Metrics.Incr("rejected") @@ -119,8 +120,10 @@ func (t Tracer) DropRPC(r *pubsub.RPC, id peer.ID) { // UndeliverableMessage is invoked when the consumer of Subscribe is not reading messages fast enough and // the pressure release mechanism trigger, dropping messages. -func (t Tracer) UndeliverableMessage(_ *pubsub.Message) { - t.Log.Warn("message undeliverable") +func (t Tracer) UndeliverableMessage(m *pubsub.Message) { + t.Log. + WithField("topic", m.GetTopic()). + Warn("message undeliverable") t.Metrics.Incr("undeliverable") }