Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weco-datascience releases #31

Merged
merged 6 commits into from
Aug 25, 2020
Merged

weco-datascience releases #31

merged 6 commits into from
Aug 25, 2020

Conversation

harrisonpim
Copy link
Contributor

@harrisonpim harrisonpim commented Aug 24, 2020

Proposed workflow:

  • make a bunch of changes in the weco_datascience directory
  • set a new version manually in the package init.py
  • PR them, merge them into master.
  • create a new release, tagged with a new semantic version. any release notes etc added through the same interface. /tags serves as the changelog.
  • workflow at .github/workflows/publish.yml is triggered by the new release, which
    • installs flit
    • lints the package
    • runs its tests
    • builds the package binary
    • publishes it to pypi

@harrisonpim harrisonpim marked this pull request as ready for review August 24, 2020 17:24
@harrisonpim
Copy link
Contributor Author

still need to add a set of PYPI_USERNAME and PYPI_PASSWORD secrets to the repo/organisation, or authorise https://pypi.org/user/wellcomedigitalplatform/ as a maintainer on the package

Copy link
Contributor

@jamieparkinson jamieparkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should go for publishing it under wellcomedigitalplatform to match our other packages

weco_datascience/__init__.py Outdated Show resolved Hide resolved
@harrisonpim
Copy link
Contributor Author

wellcomedigitalplatform secrets added to repo and authorised as an owner of the package on pypi. Should be ready to go afaict?

@harrisonpim harrisonpim merged commit 11599b6 into master Aug 25, 2020
@harrisonpim harrisonpim deleted the weco-datascience-releases branch August 25, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidy versioning for weco-datascience package CI for weco-datascience package
2 participants