Remove adminComment/note field from companies #5001
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
juniwbjerde
force-pushed
the
remove_notefield_bdb
branch
from
b8d9658
to
b0e7a5c
Compare
|
See comment on backend PR. I thought we only wanted to remove it from the table? I know it's somewhat kinda used sometimes😆😅 |
|
@ivarnakken I've answered you in the backed PR as well, but what does "somewhat kinda somethimes" mean? Falk got the impression that Bedkom never really use it as far as i understood |
I've seen it be used, but it's never been used very thoroughly. I thought we discussed that we wanted to improve the comments and make something similar to itDAGENE's system. I agree that it should be removed from the table though. Not sure if we have to remove it as a feature all together, because ideally we would want them to use it more. I guess our job is to make it more intuitive and useful. Perhaps Falk or Isak can show itDAGENE's admin page |
|
Oh I read your comment on lego now! I totally forgot we had "normal" comments as well, so in that case I'm totally in for completely yeeting it😁sorry hehe |
| dataIndex: 'comment', | ||
| // Using an empty column for filtering | ||
| title: '', | ||
| dataIndex: 'Filter', |
There was a problem hiding this comment.
| dataIndex: 'Filter', | |
| dataIndex: 'active', |
| dataIndex: 'comment', | ||
| // Using an empty column for filtering | ||
| title: '', | ||
| dataIndex: 'Filter', | ||
| centered: false, |
ivarnakken
added
the
chore
Description
Removed the field
adminCommentfrom company. It was only used in the bdb table, and just took up unnecessary space and was never really used for anything...Testing
Corresponding backend changes: webkom/lego#3643
Resolves ABA-1052