From 30e465cc2c9e7c25dd8bb2226e322b2dc7d7c1c7 Mon Sep 17 00:00:00 2001 From: neverland Date: Sun, 1 Sep 2024 15:02:45 +0800 Subject: [PATCH] fix: escape characters in compilationId (#3334) --- packages/core/src/server/helper.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/core/src/server/helper.ts b/packages/core/src/server/helper.ts index da44fc264..76ff9aecb 100644 --- a/packages/core/src/server/helper.ts +++ b/packages/core/src/server/helper.ts @@ -384,9 +384,13 @@ export const getAddressUrls = ({ }; // A unique name for WebSocket communication +const COMPILATION_ID_REGEX = /[^a-zA-Z0-9_-]/g; export const getCompilationId = ( compiler: Rspack.Compiler | Rspack.Compilation, -) => `${compiler.name ?? ''}_${compiler.options.output.uniqueName ?? ''}`; +) => { + const uniqueName = compiler.options.output.uniqueName ?? ''; + return `${compiler.name ?? ''}_${uniqueName.replace(COMPILATION_ID_REGEX, '_')}`; +}; export function getServerTerminator( server: Server | Http2SecureServer,