Property 'children' is incompatible with index signature TS Error

[richbachman]

Description

I'm not sure if this is a bug or not but figured I'd post an issue here. I'm running into a TS error when trying to create a Button component from Box. It only seems to happen if I add colorProperties to the createRainbowSprinkles function. You can see the CodeSandbox here: https://codesandbox.io/s/musing-antonelli-nh703c?file=/components/Box.css.ts:2421-2464

Expected Behaviour

I should be able to add colorProperties to the createRainbowSprinkles function.

Actual Behaviour

The TS error is Property 'children' is incompatible with index signature. You can see that on Button: https://codesandbox.io/s/musing-antonelli-nh703c?file=/components/Button.tsx

Affected Version

0.15.1

Steps to Reproduce

I've shared the CodeSandbox. You can remove the TS error by commenting out this line: https://codesandbox.io/s/musing-antonelli-nh703c?file=/components/Box.css.ts:2755-2773

Checklist

• I have read the contributing guidelines
• I have verified this does not duplicate an existing issue

[roginfarrer]

The bug appears to go away if you add the shorthands property to colorProperties. Looks to be a bug with the types!

[richbachman]

@roginfarrer thanks for taking a look at this so quickly. Sure enough, just adding shorthands: {} fixes the issue. When you say a bug with types, would that be on the library's end or something I'm doing incorrectly?

[roginfarrer]

It's a bug within rainbow sprinkles

[roginfarrer]

I've looked into this a little bit, but I'm not 100% sure how to solve it 🤔 . Would love some help on this one.

[roginfarrer]

I think I may have fixed this issue. @richbachman can you try installing this version and see if it fixes it for you?

0.0.0-reorder-defineproperties-overload-types-20240102060747

[roginfarrer]

Went ahead and merged it since I'm pretty confident it fixes the issue in my testing. Will release in a patch shortly.

[richbachman]

@roginfarrer Apologies for falling off the radar on this one. Work has been busy and my brain is playing catch up. Thanks for looking into this. I'll take a look.