Fixed class creation being skipped when property values are zero (#90)

wayfair · Dec 6, 2022 · 19bd82c · 19bd82c
1 parent 705422f
commit 19bd82c
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 1 deletion.
diff --git a/.changeset/little-olives-hang.md b/.changeset/little-olives-hang.md
@@ -0,0 +1,5 @@
+---
+'rainbow-sprinkles': patch
+---
+
+Fixed classes not being created when property value is 0
diff --git a/packages/rainbow-sprinkles/src/__tests__/assignClasses.test.ts b/packages/rainbow-sprinkles/src/__tests__/assignClasses.test.ts
@@ -115,3 +115,26 @@ test('supports number values', () => {
 
   expect(assignClasses(config, 'foo')).toBe('a');
 });
+
+test('supports 0 values', () => {
+  const config: CreateStylesOutput = {
+    dynamic: {
+      default: 'a',
+      conditions: { mobile: 'a', tablet: 'b', desktop: 'c' },
+    },
+    name: 'flexShrink',
+    vars: {
+      conditions: { mobile: 'a', tablet: 'b', desktop: 'c' },
+      default: 'a',
+    },
+  };
+
+  expect(
+    assignClasses(config, {
+      mobile: 0,
+      tablet: 1,
+    }),
+  ).toBe('a b');
+
+  expect(assignClasses(config, 0)).toBe('a');
+});
diff --git a/packages/rainbow-sprinkles/src/assignClasses.ts b/packages/rainbow-sprinkles/src/assignClasses.ts
@@ -5,7 +5,7 @@ export function assignClasses(
   propertyConfig: CreateStylesOutput,
   propValue: unknown,
 ): string {
-  if (!propValue) {
+  if (!propValue && propValue !== 0) {
     return '';
   }