Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safe exec of 'git checkout' #95

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Conversation

kurt-r2c
Copy link
Contributor

@kurt-r2c kurt-r2c commented Nov 2, 2022

Proposed Changes

Fix for variant of CVE-2021-26543 if user-supplied commit hash is untrusted

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Test Plan and Documentation

same fix as CVE-2021-26543 - https://github.com/wayfair/git-parse/pull/18/files

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

fix potential command injection w/user-controlled hash
@erj826
Copy link
Collaborator

erj826 commented Nov 7, 2022

Looks good to me! Can approve once you run prettier and add a note to the changelog mentioning this change.

@kurt-r2c
Copy link
Contributor Author

kurt-r2c commented Nov 7, 2022

I think all of the major boxes have now been checked - I did not check the commit message linter job before starting this patch and so that check is probably doomed to fail forever, but otherwise I think this is now good for a maintainer to merge - I can't do it myself

@erj826 erj826 merged commit f15c438 into wayfair:main Nov 8, 2022
@kurt-r2c
Copy link
Contributor Author

kurt-r2c commented Nov 8, 2022

@erj826 @kv979w would you like me to wait for a release before publishing information about this patch

@finn-orsini
Copy link
Collaborator

@kurt-r2c I've prepped a PR with the version bump, should be able to release by EOD tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants