Fix incorrect proxyURL with terragruntURL #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@warrensbox 👋 Hey! Sorry to tag. I just think this could be quite a quick an easy fix and should hopefully fix some problems folks have been reporting 🙏 |
|
@warrensbox Bump :) |
|
I'm running into this same issue, hope to see this PR merged or another fix soon! |
|
@warrensbox please merge this^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #133
I believe this function should not be called with the proxyURL (which is the URL to your cache of Terragrunt versions), instead the Terragrunt mirror URL. Ultimately this is passed through to the download function, which uses the mirrorURL (parameter) to construct the download path for a version.
This is why we sometimes see 404s (when this particular block/case is encountered) - it's trying to download the binary from this repo!
Hope the PR Is okay and this makes sense?