Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow Env vars in TOML bin value (re-introduce feature) #467

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix: Allow Env vars in TOML bin value (re-introduce feature) #467

merged 1 commit into from
Jun 19, 2024

Conversation

yermulnik
Copy link
Collaborator

  • fix: Allow Env vars in TOML bin value again
  • chore: While was investigating, committed tiny cleanup/improvements in lib/files.go

@yermulnik yermulnik changed the title fix: Allow Env vars in TOML bin value again fix: Allow Env vars in TOML bin value (re-introduce feature) Jun 14, 2024
MatthewJohn
MatthewJohn approved these changes Jun 14, 2024
View reviewed changes
lib/param_parsing/toml.go Show resolved Hide resolved
@yermulnik yermulnik merged commit b4e814f into master Jun 19, 2024
3 checks passed
@yermulnik yermulnik deleted the fix/allow_env_vars_in_bin_toml_parameter branch June 19, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewJohn MatthewJohn MatthewJohn approved these changes

@warrensbox warrensbox warrensbox approved these changes

@jukie jukie Awaiting requested review from jukie jukie is a code owner

@MatrixCrawler MatrixCrawler Awaiting requested review from MatrixCrawler MatrixCrawler is a code owner

@crablab crablab Awaiting requested review from crablab crablab is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yermulnik @MatthewJohn @warrensbox