Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error return values to signatures of public methods to allow migrating to returning errors rather than Fatals in future #457

Merged
merged 8 commits into from
Jun 20, 2024
Merged

Add error return values to signatures of public methods to allow migrating to returning errors rather than Fatals in future #457

merged 8 commits into from
Jun 20, 2024

Commits on Jun 8, 2024

  1. Add error return values to signatures of public methods to allow migr… 

    …ating to returning errors rather than Fatals in future
    @MatthewJohn
    MatthewJohn committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    09975ed View commit details
    Browse the repository at this point in the history

  2. Update InstallLatestProductVersion to specify return value of error

    @MatthewJohn
    MatthewJohn committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    4ea15a4 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Update main.go to handle error return values from methods, print to u… 

    …ser and exit with RC 1
    @MatthewJohn
    MatthewJohn committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f2dc60f View commit details
    Browse the repository at this point in the history

  2. Return errors instead of fatal logging and exits in public methods (n… 

    …ot including methods called by the public method)
    @MatthewJohn
    MatthewJohn committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e247792 View commit details
    Browse the repository at this point in the history

  3. fix: Update '--latest' flag handling to respect '--product' flag. 

    Use InstallLatestProductVersion, passing in product and handled returned error
    @MatthewJohn
    MatthewJohn committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    97c27de View commit details
    Browse the repository at this point in the history

  4. Fix typo in error 

    Co-authored-by: George L. Yermulnik <yz@yz.kiev.ua>
    @MatthewJohn @yermulnik
    MatthewJohn and yermulnik committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    bc1a300 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into add-error-return-value-public-methods

    @MatthewJohn
    MatthewJohn committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    2b27273 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Switch log.Error and Exit with Fatal in main

    @MatthewJohn
    MatthewJohn committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    d63011a View commit details
    Browse the repository at this point in the history